Cleanup cgroup_summary collector #2414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuperQ
force-pushed
the
superq/cgroup_cleanup
branch
2 times, most recently
from
905dbbb to
a42dace
Compare
|
@SuperQ looks like the script is not happy with the name of the metric :) |
|
Hmm, that's an annoying linter error. I guess we could just call this collector |
* Correctly name collector file. * Fix cgroup summary type as gauge. * Use a boolean metric rather than a label for enabled. Signed-off-by: Ben Kochie <[email protected]>
SuperQ
force-pushed
the
superq/cgroup_cleanup
branch
from
a42dace to
1de82b3
Compare
|
Ok, all fixed up. |
|
mmm that means there is a breaking change in the collector name and in its behaviour ( it's a counter anymore but a gauge). I'm not super familiar with the release political on this project, but the code looks ok. |
|
This change was just merged today, and has not been released, so not breaking. |
oblitorum
pushed a commit
to shatteredsilicon/node_exporter
that referenced
this pull request
Apr 9, 2024
* Correctly name collector file. * Fix cgroup summary type as gauge. * Use a boolean metric rather than a label for enabled. Signed-off-by: Ben Kochie <[email protected]>
oblitorum
pushed a commit
to shatteredsilicon/node_exporter
that referenced
this pull request
Apr 9, 2024
* Correctly name collector file. * Fix cgroup summary type as gauge. * Use a boolean metric rather than a label for enabled. Signed-off-by: Ben Kochie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ben Kochie [email protected]