Ignore filesystems flagged as MNT_IGNORE. #2227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes prometheus#2152. Signed-off-by: Lapo Luchini <[email protected]>
lapo-luchini
changed the title
|
Probably historical reasons. Feel free to change them to use the unix package as well. But either way, this LGTM! |
Signed-off-by: Lapo Luchini <[email protected]>
Done! I'd say this PR is ready (IMHO). |
SuperQ
approved these changes
Nov 29, 2021
discordianfish
approved these changes
Nov 30, 2021
|
@discordianfish Would you call this a |
|
Yeah bugfix sounds good but change would be fine as well. Whatever you prefer! |
SuperQ
added a commit
that referenced
this pull request
Dec 1, 2021
* [BUGFIX] Handle nil CPU thermal power status on M1 #2218 * [BUGFIX] bsd: Ignore filesystems flagged as MNT_IGNORE. #2227 * [BUGFIX] Sanitize UTF-8 in dmi collector #2229 Signed-off-by: Ben Kochie <[email protected]>
Merged
SuperQ
added a commit
that referenced
this pull request
Dec 4, 2021
* [BUGFIX] Handle nil CPU thermal power status on M1 #2218 * [BUGFIX] bsd: Ignore filesystems flagged as MNT_IGNORE. #2227 * [BUGFIX] Sanitize UTF-8 in dmi collector #2229 Signed-off-by: Ben Kochie <[email protected]>
SuperQ
pushed a commit
that referenced
this pull request
Dec 4, 2021
* Ignore filesystems flagges as MNT_IGNORE. Closes #2152. Signed-off-by: Lapo Luchini <[email protected]>
SuperQ
added a commit
that referenced
this pull request
Dec 4, 2021
* [BUGFIX] Handle nil CPU thermal power status on M1 #2218 * [BUGFIX] bsd: Ignore filesystems flagged as MNT_IGNORE. #2227 * [BUGFIX] Sanitize UTF-8 in dmi collector #2229 Signed-off-by: Ben Kochie <[email protected]>
Merged
oblitorum
pushed a commit
to shatteredsilicon/node_exporter
that referenced
this pull request
Apr 9, 2024
* Ignore filesystems flagges as MNT_IGNORE. Closes prometheus#2152. Signed-off-by: Lapo Luchini <[email protected]>
oblitorum
pushed a commit
to shatteredsilicon/node_exporter
that referenced
this pull request
Apr 9, 2024
* [BUGFIX] Handle nil CPU thermal power status on M1 prometheus#2218 * [BUGFIX] bsd: Ignore filesystems flagged as MNT_IGNORE. prometheus#2227 * [BUGFIX] Sanitize UTF-8 in dmi collector prometheus#2229 Signed-off-by: Ben Kochie <[email protected]>
oblitorum
pushed a commit
to shatteredsilicon/node_exporter
that referenced
this pull request
Apr 9, 2024
* Ignore filesystems flagges as MNT_IGNORE. Closes prometheus#2152. Signed-off-by: Lapo Luchini <[email protected]>
oblitorum
pushed a commit
to shatteredsilicon/node_exporter
that referenced
this pull request
Apr 9, 2024
* [BUGFIX] Handle nil CPU thermal power status on M1 prometheus#2218 * [BUGFIX] bsd: Ignore filesystems flagged as MNT_IGNORE. prometheus#2227 * [BUGFIX] Sanitize UTF-8 in dmi collector prometheus#2229 Signed-off-by: Ben Kochie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2152.
I noticed that
MNT_READONLYandMNT_NOWAITare available underunixdependency as well, is there a reason they were defined as local constants instead of relying on the external library?In this PR I made the shortest change possible and used the library for the new flag, but if you'd like me to use this PR to change those two as well (or, on the opposite, define also this third one as local constant), tell me.