Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Go modules #1705

Merged
merged 3 commits into from
May 15, 2020
Merged

Update Go modules #1705

merged 3 commits into from
May 15, 2020

Conversation

SuperQ
Copy link
Member

@SuperQ SuperQ commented May 14, 2020

  • Bump to Go 1.14 minimum version.
  • Update vendoring

Fixes: #1704

Signed-off-by: Ben Kochie [email protected]

* Bump to Go 1.14 minimum version.
* Update vendoring

Fixes: #1704

Signed-off-by: Ben Kochie <[email protected]>
@SuperQ SuperQ requested a review from roidelapluie May 14, 2020 17:47
SuperQ added 2 commits May 14, 2020 19:47
Signed-off-by: Ben Kochie <[email protected]>
Upstream x/sys/unix changed types.

Signed-off-by: Ben Kochie <[email protected]>
@roidelapluie
Copy link
Member

Did you try prometheus/prometheus#7259 ?

@SuperQ
Copy link
Member Author

SuperQ commented May 14, 2020

Not yet. :)

Copy link
Member

@discordianfish discordianfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SuperQ SuperQ merged commit 73aec06 into master May 15, 2020
@SuperQ SuperQ deleted the bjk/update_mod branch May 15, 2020 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

go.mod says 1.13 required, but 1.14 required
3 participants