docs/node-mixin/dashboards: do not mix tabs and spaces #1532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: paulfantom <[email protected]>
paulfantom
force-pushed
the
dont_mix_tabs_and_spaces
branch
from
f015a21 to
4057092
Compare
metalmatze
approved these changes
Nov 1, 2019
s-urbaniak
approved these changes
Nov 1, 2019
|
Sorry, so used to get my jsonnet checked by the CI that I didn't pay attention here. Thanks! |
beorn7
approved these changes
Nov 1, 2019
|
@beorn7 maybe we should add such check to CI? In prometheus-operator we already build and release a jsonnet-ci container image which contains |
|
Sure, that would be best. And then we should do it for all repos with mixins (currently node-exporter and prometheus, but soon alertmanager, a branch for the latter already exists). PRs welcome… :o) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is completely breaking node-mixins as
jsonnetfmtpanics with:/cc @beorn7 @s-urbaniak @metalmatze