Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update procfs to v0.0.3-0.20190620161747-f959769dfe3e #1395

Merged
merged 1 commit into from
Jun 25, 2019

Conversation

bdrung
Copy link
Contributor

@bdrung bdrung commented Jun 25, 2019

procfs v0.0.3-0.20190620161747-f959769dfe3e is a requirement for
#1357

@pgier
Copy link
Contributor

pgier commented Jun 25, 2019

@bdrung I created a procfs v0.0.3 tag (https://github.com/prometheus/procfs/releases/tag/v0.0.3) in case you want to update to that one instead.

procfs v0.0.3 is a requirement for
prometheus#1357

Signed-off-by: Benjamin Drung <[email protected]>
@bdrung
Copy link
Contributor Author

bdrung commented Jun 25, 2019

Thanks. I updated the pull request to upgrade to procfs v0.0.3

@AvengerMoJo
Copy link

@pgier I believe that include my update for the iscsi procfs module as well?

Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SuperQ SuperQ merged commit 4f074df into prometheus:master Jun 25, 2019
@bdrung bdrung deleted the upgrade-procfs branch June 25, 2019 19:34
@pgier
Copy link
Contributor

pgier commented Jun 25, 2019

@AvengerMoJo Yes, this version includes the latest iscsi update.

oblitorum pushed a commit to shatteredsilicon/node_exporter that referenced this pull request Apr 9, 2024
procfs v0.0.3 is a requirement for
prometheus#1357

Signed-off-by: Benjamin Drung <[email protected]>
oblitorum pushed a commit to shatteredsilicon/node_exporter that referenced this pull request Apr 9, 2024
procfs v0.0.3 is a requirement for
prometheus#1357

Signed-off-by: Benjamin Drung <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants