Add fallback for missing /proc/1/mounts #1172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Is it sane to add a regression test for this? Might also want a debug log. |
|
Yea, we can make an extra fixtures directory for this. |
On some systems, `/proc/1/mounts` is hidden from non-root users due to the `hidepid` procfs feature. Attempt to fallback to `/proc/mounts` if `/proc/1/mounts` is not found. Signed-off-by: Ben Kochie <[email protected]>
SuperQ
force-pushed
the
superq/hidepid
branch
from
a25d338 to
fc838d4
Compare
Signed-off-by: Ben Kochie <[email protected]>
SuperQ
force-pushed
the
superq/hidepid
branch
from
fc838d4 to
19f247d
Compare
Signed-off-by: Ben Kochie <[email protected]>
|
👍 |
SuperQ
added a commit
that referenced
this pull request
Nov 30, 2018
* Add fallback for missing /proc/1/mounts On some systems, `/proc/1/mounts` is hidden from non-root users due to the `hidepid` procfs feature. Attempt to fallback to `/proc/mounts` if `/proc/1/mounts` is not found. Signed-off-by: Ben Kochie <[email protected]> * Add tests. Signed-off-by: Ben Kochie <[email protected]> * Add CHANGELOG entry. Signed-off-by: Ben Kochie <[email protected]>
SuperQ
added a commit
that referenced
this pull request
Nov 30, 2018
* Add fallback for missing /proc/1/mounts On some systems, `/proc/1/mounts` is hidden from non-root users due to the `hidepid` procfs feature. Attempt to fallback to `/proc/mounts` if `/proc/1/mounts` is not found. Signed-off-by: Ben Kochie <[email protected]> * Add tests. Signed-off-by: Ben Kochie <[email protected]> * Add CHANGELOG entry. Signed-off-by: Ben Kochie <[email protected]>
simonmeggle
added a commit
to simonmeggle/node_exporter
that referenced
this pull request
Feb 18, 2019
Signed-off-by: Simon Meggle <[email protected]>
oblitorum
pushed a commit
to shatteredsilicon/node_exporter
that referenced
this pull request
Apr 9, 2024
* Add fallback for missing /proc/1/mounts On some systems, `/proc/1/mounts` is hidden from non-root users due to the `hidepid` procfs feature. Attempt to fallback to `/proc/mounts` if `/proc/1/mounts` is not found. Signed-off-by: Ben Kochie <[email protected]> * Add tests. Signed-off-by: Ben Kochie <[email protected]> * Add CHANGELOG entry. Signed-off-by: Ben Kochie <[email protected]>
oblitorum
pushed a commit
to shatteredsilicon/node_exporter
that referenced
this pull request
Apr 9, 2024
* Add fallback for missing /proc/1/mounts On some systems, `/proc/1/mounts` is hidden from non-root users due to the `hidepid` procfs feature. Attempt to fallback to `/proc/mounts` if `/proc/1/mounts` is not found. Signed-off-by: Ben Kochie <[email protected]> * Add tests. Signed-off-by: Ben Kochie <[email protected]> * Add CHANGELOG entry. Signed-off-by: Ben Kochie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some systems,
/proc/1/mountsis hidden from non-root users due tothe
hidepidprocfs feature. Attempt to fallback to/proc/mountsif/proc/1/mountsis not found.Fixes: #1171
Signed-off-by: Ben Kochie [email protected]