Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore additional virtual filesystems #1104

Merged
merged 1 commit into from
Oct 12, 2018
Merged

Ignore additional virtual filesystems #1104

merged 1 commit into from
Oct 12, 2018

Conversation

SuperQ
Copy link
Member

@SuperQ SuperQ commented Oct 11, 2018

Add more virtual filesystems to the default ignore list

  • bpf
  • cgroup2
  • selinuxfs
  • squashfs

Signed-off-by: Ben Kochie [email protected]

@SuperQ SuperQ requested a review from discordianfish October 11, 2018 07:50
@brian-brazil
Copy link
Contributor

squashfs too, as it's readonly.

@SuperQ
Copy link
Member Author

SuperQ commented Oct 11, 2018

I think we want to keep squashfs in because it reports a non-zero size.

@brian-brazil
Copy link
Contributor

The Snap packaging system uses squashfs, so can get a little spammy.

Copy link
Member

@discordianfish discordianfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SuperQ
Copy link
Member Author

SuperQ commented Oct 11, 2018

@discordianfish What do you think about adding squashfs?

@discordianfish
Copy link
Member

Yeah lets add squashfs

Add more virtual filesystems to the default ignore list
* bpf
* cgroup2
* selinuxfs
* squashfs

Signed-off-by: Ben Kochie <[email protected]>
@SuperQ SuperQ force-pushed the superq/more_virtfs branch from d69c1f2 to c5f5936 Compare October 12, 2018 08:51
@SuperQ
Copy link
Member Author

SuperQ commented Oct 12, 2018

Added squashfs. Also cgroup2 pointed out by @rtreffer.

@SuperQ SuperQ merged commit 0880d46 into master Oct 12, 2018
@SuperQ SuperQ deleted the superq/more_virtfs branch October 12, 2018 09:24
oblitorum pushed a commit to shatteredsilicon/node_exporter that referenced this pull request Apr 9, 2024
Add more virtual filesystems to the default ignore list
* bpf
* cgroup2
* selinuxfs
* squashfs

Signed-off-by: Ben Kochie <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants