Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics for kernel vulnerabilities #1046

Closed
bobrik opened this issue Aug 15, 2018 · 4 comments · Fixed by #2721
Closed

Metrics for kernel vulnerabilities #1046

bobrik opened this issue Aug 15, 2018 · 4 comments · Fixed by #2721

Comments

@bobrik
Copy link

bobrik commented Aug 15, 2018

Newer kernels have this:

$ ls /sys/devices/system/cpu/vulnerabilities
meltdown  spectre_v1  spectre_v2
$ cat /sys/devices/system/cpu/vulnerabilities/meltdown
Mitigation: PTI

I wonder if we should export these as metrics in node_exporter:

node_kernel_vulnerabilities{name="meltdown", value="Mitigation: PTI"} 1
@discordianfish
Copy link
Member

Seems reasonable feature request. But parsing of this should go into procfs.

@knweiss
Copy link
Contributor

knweiss commented Aug 22, 2018

Side note: spectre-meltdown-checker has a --batch prometheus option and is able to export the kernel Spectre/Meltdown vulnerability status via node-exporter's textfile collector. Example.

bobrik added a commit to bobrik/procfs that referenced this issue Aug 22, 2018
discordianfish pushed a commit to prometheus/procfs that referenced this issue Jul 12, 2019
discordianfish pushed a commit to prometheus/procfs that referenced this issue Jul 12, 2019
pgier pushed a commit to prometheus/procfs that referenced this issue Aug 22, 2019
remijouannet pushed a commit to remijouannet/procfs that referenced this issue Oct 20, 2022
@palash25
Copy link

palash25 commented Nov 6, 2022

hi i was looking to contribute and just wanted to know is this still a valid feature request? as i see the vulnerability parsing code was added to procfs https://github.com/prometheus/procfs/pull/190/files but the CPUVulnerabilities() method is not used anywhere in node_exporter, is there a reason for not using it? and is this issue still up for grabs?

@discordianfish
Copy link
Member

@palash25 Unless I missed some open PR, yeah a PR to add a collector for this here is very welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants