Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http_config: Allow customizing TLS config and settings. #748

Merged
merged 3 commits into from
Jan 16, 2025

Conversation

bwplotka
Copy link
Member

We (Google) would love to modify TLS config for custom authorization settings for our environments. Sometimes it means literally using our internal Go tls.Config instead of the created one by this client. This PR adds a minimal change to support a single option to do that, hope that makes sense!

@bwplotka bwplotka requested a review from SuperQ January 16, 2025 09:28
config/http_config.go Outdated Show resolved Hide resolved
config/http_config.go Outdated Show resolved Hide resolved
Signed-off-by: bwplotka <[email protected]>
Copy link

@machine424 machine424 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks.
(ok to change the default from NewTLSConfig to NewTLSConfigWithContext)

@bwplotka bwplotka merged commit 280b0e7 into main Jan 16, 2025
8 checks passed
@bwplotka bwplotka deleted the extendtlsconfig branch January 16, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants