Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

promslog: always lowercase log level from CLI #728

Merged
merged 1 commit into from
Dec 4, 2024
Merged

promslog: always lowercase log level from CLI #728

merged 1 commit into from
Dec 4, 2024

Conversation

jkroepke
Copy link
Contributor

@jkroepke jkroepke commented Dec 1, 2024

The --log.level argument now relaxes casing by converting all input from end-users to lowercase.

This allows end-users to set log.level to values like DEBUG.

@beorn7 beorn7 requested a review from SuperQ December 3, 2024 18:18
SuperQ
SuperQ approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, thanks!

@SuperQ SuperQ merged commit b88f24c into prometheus:main Dec 4, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperQ SuperQ SuperQ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkroepke @SuperQ