Improve OAuth2 user agent handling #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of relying on the User Agent in the configuration, take the User Agent of the original request. This enables compatibility with existing user agents. Signed-off-by: Julien Pivotto <[email protected]>
radek-ryckowski
pushed a commit
to goldmansachs/common
that referenced
this pull request
May 18, 2023
Instead of relying on the User Agent in the configuration, take the User Agent of the original request. This enables compatibility with existing user agents. Signed-off-by: Julien Pivotto <[email protected]>
radek-ryckowski
pushed a commit
to goldmansachs/common
that referenced
this pull request
May 22, 2023
Instead of relying on the User Agent in the configuration, take the User Agent of the original request. This enables compatibility with existing user agents. Signed-off-by: Julien Pivotto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of relying on the User Agent in the configuration, take the User
Agent of the original request. This enables compatibility with existing
user agents.
Signed-off-by: Julien Pivotto [email protected]