fix: support aws_tag_select with non-standard resource id in metric

[msvticket]

Fixes #268

@matthiasr I'll add an update to the README when I get the word that the code is at least in the ball park ready to be merged.

[matthiasr]

Thank you for tackling this! I like giving users the option to supply patterns.

I see that we can both encode known patterns in ARN_RESOURCE_ID_REGEXP_FOR_TYPE and allow configuring custom patterns. What guidance can we give future contributors on whether they should add patterns to the code or the examples?

Would it be "good enough" to keep the exporter oblivious of specific patterns, and only add the elasticloadbalancing:targetgroup to the examples?

[matthiasr]

Will this replace the workaround outlined in #571 or is it separate?

[msvticket]

Thank you for tackling this! I like giving users the option to supply patterns.

I see that we can both encode known patterns in ARN_RESOURCE_ID_REGEXP_FOR_TYPE and allow configuring custom patterns. What guidance can we give future contributors on whether they should add patterns to the code or the examples?

Would it be "good enough" to keep the exporter oblivious of specific patterns, and only add the elasticloadbalancing:targetgroup to the examples?

For me it would be good enough, but for the general user it would certainly be preferable for as a much as possible to work out of the box.

[msvticket]

Will this replace the workaround outlined in #571 or is it separate?

It would replace the label_replace trick.

[matthiasr]

general user it would certainly be preferable for as a much as possible to work out of the box

I'm afraid this exporter does not work "out of the box" at all 😬

The example configurations are the main way to "get started", and where we do collect service specifics, so I think to keep things clear and maintainable going forward, I would rather remove ARN_RESOURCE_ID_REGEXP_FOR_TYPE and add it to the relevant example configurations instead.

[matthiasr]

This has the added benefit of showing how to use it, so that hopefully users for other services can help themselves without having to wait for exporter code changes and releases.

[matthiasr]

Awesome!

…

On Sun, Mar 3, 2024 at 4:08 PM Mårten Svantesson ***@***.***> wrote: Will this replace the workaround outlined in #571 <#571> or is it separate? It would replace the label_replace trick. — Reply to this email directly, view it on GitHub <#648 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABAEBTXLLNBK3J3TI2QUHLYWM4HTAVCNFSM6AAAAABDAE7NZ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZVGE4TEMBVHA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[msvticket]

I have now removed ARN_RESOURCE_ID_REGEXP_FOR_TYPE from the code. I'll look at documentation soon

[msvticket]

Now I have documented the new option and updated a couple of examples to use it

[matthiasr]

Awesome, thank you! Merging despite the build_image failure – build succeeded, and the Docker version issue is resolved in master.