Disallow TRACE HTTP method #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even though I believe there is no actual risk of [Cross-Site Tracing][xst] attacks in cloudwatch-exporter, disallowing the `TRACE` HTTP method in Jetty reduces attack surface and makes security scans happier. (Non-embedded) Jetty disables `TRACE` [in the default configuration][jetty-webapp] by forcing requests using that method be authenticated. I thought using a customizer would be cleaner and, as a bonus, would also be able to return a more accurate HTTP status code (405 Method Not Allowed). [xst]: https://owasp.org/www-community/attacks/Cross_Site_Tracing [jetty-webapp]: https://github.com/eclipse/jetty.project/blob/jetty-11.0.11/jetty-webapp/src/main/config/etc/webdefault.xml#L423-L440 Signed-off-by: Pedro Araujo <[email protected]>
|
@matthiasr can you have a look? |
|
Awesome, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though I believe there is no actual risk of Cross-Site Tracing attacks in cloudwatch-exporter, disallowing
the
TRACEHTTP method in Jetty reduces attack surface and makes security scans happier.(Non-embedded) Jetty disables
TRACEin the default configuration by forcing requests using that method be authenticated. I thought using a customizer would be cleaner and, as a bonus, would also be able to return a more accurate HTTP status code (405 Method Not Allowed).