-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use RecentlyActive
feature to only list metrics older than 3 hours when necessary
#296
Use RecentlyActive
feature to only list metrics older than 3 hours when necessary
#296
Conversation
Signed-off-by: Nathan Beneke <[email protected]>
Signed-off-by: Nathan Beneke <[email protected]>
Signed-off-by: Nathan Beneke <[email protected]>
Signed-off-by: Nathan Beneke <[email protected]>
If we're using this it shouldn't be configurable, we already know the range_seconds in use. |
So you would suggest to set this option if |
Yes. |
Signed-off-by: Nathan Beneke <[email protected]>
@brian-brazil I agree that's a lot simpler actually. Changed it to do that and updated the test to make sure that it's actually still possible to get metrics older than 3 hours with this setup |
RecentlyActive
feature to only list metrics older than 3 hours when necessary
I see this was also talked about in this open issue but never pursued further. With regard to the concern with S3 and similar metrics, I think it's okay because for those metrics the |
Thanks! |
Hey @brian-brazil |
As-needed basically, I've added it to my todo list. |
Hi @brian-brazil should we expect a new release with this in the next week(s), month(s)? Thanks. |
I have the problem that a lot of the dimensions on my CloudWatch metrics change frequently. Because the default behaviour of
listMetrics()
is to return every metric that matches your query and has been updated in the last 2 weeks, this causes the scrape time to be very high. With this option, we can limit the returned metrics to only those which have been updated in the last 3 hours. I also had to update the AWS SDK to allow this, as the version currently being used doesn't have this featurecc @brian-brazil