Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare release 4.0.0 #252

Merged
merged 3 commits into from
Mar 27, 2022
Merged

Prepare release 4.0.0 #252

merged 3 commits into from
Mar 27, 2022

Conversation

Sinjo
Copy link
Member

@Sinjo Sinjo commented Mar 26, 2022

No description provided.

@Sinjo Sinjo requested a review from dmagliola March 26, 2022 23:40
Signed-off-by: Chris Sinjakli <[email protected]>
@Sinjo Sinjo force-pushed the sinjo-prepare-4-0 branch from 4d75e21 to 9de0a22 Compare March 26, 2022 23:41
Copy link
Collaborator

@dmagliola dmagliola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The second commit message should say "CHANGELOG", not "README".

Not sure if you care, happy to leave as is and 🚢

@Sinjo Sinjo force-pushed the sinjo-prepare-4-0 branch from 9de0a22 to 05823a8 Compare March 26, 2022 23:57
@Sinjo
Copy link
Member Author

Sinjo commented Mar 26, 2022

Good catch!

(I do care)

@Sinjo Sinjo merged commit 8740786 into master Mar 27, 2022
@Sinjo Sinjo deleted the sinjo-prepare-4-0 branch March 27, 2022 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants