Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated docs with code to remove default metrics #827

Merged
merged 1 commit into from
Oct 11, 2022

Conversation

sss-ng
Copy link
Contributor

@sss-ng sss-ng commented Aug 1, 2022

I spent a while trying to figure out how to remove these default metrics. Im updating the docs with instructions to remove process, gc, and platform collector metrics.

Please let me know if my language regarding prometheus is correct, and I will gladly update it

@sss-ng sss-ng force-pushed the docs/remove-default-metrics branch from 73d381f to 21a7e9a Compare August 2, 2022 02:26
Copy link
Member

@csmarchbanks csmarchbanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, thank you for the contribution. I am wondering if it is also worthwhile to mention that you can just create a new registry and use that registry instead of the default registry to avoid having the default collectors. Going with the new registry approach will also mean that any future default collectors will not need to be unregistered.

@csmarchbanks
Copy link
Member

Merging this, we can always add the additional suggested documentation later if we want.

@csmarchbanks csmarchbanks merged commit 71fb75d into prometheus:master Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants