add support for guava instrumentation with 1.X.X #979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Petar Heyken <[email protected]>
Signed-off-by: Petar Heyken <[email protected]>
pheyken
force-pushed
the
prometheus-metrics-instrumentation-guava-keep-history
branch
from
267c1e6 to
f7c4bca
Compare
|
@pheyken merged. Thanks for the PR! |
pheyken
deleted the
prometheus-metrics-instrumentation-guava-keep-history
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all, this is my attempt on migrating one of the simpleclient collectors over to the new Prometheus 1.X Client. This is supposed to behave exactly the same as simpleclient_guava, thus keeping the exact same metrics and the same naming. Let me know if you see any issue with this and I'm happy to adopt the Collector