-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go.mod: Set minimal support version of go to 1.15 #980
Conversation
As requested in prometheus/common#353 (comment) Signed-off-by: Manuel Rüger <[email protected]>
Since this library is so widely used, we usually only bump the version requirement if we really have to (i.e. because there is code requiring the more recent version). Supporting the last two or three Go versions is a minimal requirement (i.e. we would use build tags and such for features requiring newer Go versions). As long as older Go versions still work without additional hassle, we should IMHO keep the support. |
Thanks for the feedback and I probably should have explained this better here. Unfortunately I believe it needs to be raised due to the x/net dependency upgraded in prometheus/common#348 to mitigate a potential vuln. With the upgraded x/net, prometheus/common doesn't seem to work with earlier versions of go than 1.15. @roidelapluie and @SuperQ can chime in, in which order the change should enter as this repo also depends on prometheus/common. |
OK, a security update of a dependency, thereby having dependencies requiring newer Go versions, sounds like a good reason. That context wasn't clear to me. |
Apologies again for not providing that context earlier. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'm not sure we need to cut a release for these changes. |
I've updated the branch protection rules to reflect this change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for taking care of it.
As requested in prometheus/common#353 (comment)