Save memory on histograms: slightly faster with less code #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* one allocation for duo instantiations * use index overflow instead of redundant last state field name old time/op new time/op delta HistogramWithLabelValues-12 204ns ± 0% 204ns ± 0% ~ (all equal) HistogramNoLabels-12 41.1ns ± 0% 40.5ns ± 0% ~ (p=1.000 n=1+1) HistogramObserve1-12 33.1ns ± 0% 33.9ns ± 0% ~ (p=1.000 n=1+1) HistogramObserve2-12 132ns ± 0% 122ns ± 0% ~ (p=1.000 n=1+1) HistogramObserve4-12 377ns ± 0% 364ns ± 0% ~ (p=1.000 n=1+1) HistogramObserve8-12 1.00µs ± 0% 0.96µs ± 0% ~ (p=1.000 n=1+1) HistogramWrite1-12 1.80µs ± 0% 1.76µs ± 0% ~ (p=1.000 n=1+1) HistogramWrite2-12 3.28µs ± 0% 3.25µs ± 0% ~ (p=1.000 n=1+1) HistogramWrite4-12 6.66µs ± 0% 6.66µs ± 0% ~ (p=1.000 n=1+1) HistogramWrite8-12 13.7µs ± 0% 13.6µs ± 0% ~ (p=1.000 n=1+1) name old alloc/op new alloc/op delta HistogramWithLabelValues-12 48.0B ± 0% 48.0B ± 0% ~ (all equal) HistogramNoLabels-12 0.00B 0.00B ~ (all equal) name old allocs/op new allocs/op delta HistogramWithLabelValues-12 1.00 ± 0% 1.00 ± 0% ~ (all equal) HistogramNoLabels-12 0.00 0.00 ~ (all equal) Signed-off-by: Pascal S. de Kloe <[email protected]>
|
Note: The test failure is unrelated to this PR. It's caused by a Travis change, which I'll take care of separately. |
beorn7
requested changes
Feb 10, 2019
There was a problem hiding this comment.
Thanks for your contribution. Making the most significant bit the index bit simplifies things a lot. I really like the idea. The actual performance improvements appear very close to noise, but the code becomes cleaner (if "clean" can ever be an appropriate attribute if doing this kind of bit mangling).
On the other hand, I'm not convinced about the allocation optimizations in the constructor function. It's not really in the hot path, and it makes the code less clean.
|
If you rebase this on master, it should make the test green. |
Signed-off-by: Pascal S. de Kloe <[email protected]>
Signed-off-by: Pascal S. de Kloe <[email protected]>
|
I've borrowed some of your thinking so this is fair-trade. 😁 |
beorn7
pushed a commit
that referenced
this pull request
Feb 11, 2019
Signed-off-by: beorn7 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name old time/op new time/op delta
HistogramWithLabelValues-12 204ns ± 0% 204ns ± 0% ~ (all equal)
HistogramNoLabels-12 41.1ns ± 0% 40.5ns ± 0% ~ (p=1.000 n=1+1)
HistogramObserve1-12 33.1ns ± 0% 33.9ns ± 0% ~ (p=1.000 n=1+1)
HistogramObserve2-12 132ns ± 0% 122ns ± 0% ~ (p=1.000 n=1+1)
HistogramObserve4-12 377ns ± 0% 364ns ± 0% ~ (p=1.000 n=1+1)
HistogramObserve8-12 1.00µs ± 0% 0.96µs ± 0% ~ (p=1.000 n=1+1)
HistogramWrite1-12 1.80µs ± 0% 1.76µs ± 0% ~ (p=1.000 n=1+1)
HistogramWrite2-12 3.28µs ± 0% 3.25µs ± 0% ~ (p=1.000 n=1+1)
HistogramWrite4-12 6.66µs ± 0% 6.66µs ± 0% ~ (p=1.000 n=1+1)
HistogramWrite8-12 13.7µs ± 0% 13.6µs ± 0% ~ (p=1.000 n=1+1)
name old alloc/op new alloc/op delta
HistogramWithLabelValues-12 48.0B ± 0% 48.0B ± 0% ~ (all equal)
HistogramNoLabels-12 0.00B 0.00B ~ (all equal)
name old allocs/op new allocs/op delta
HistogramWithLabelValues-12 1.00 ± 0% 1.00 ± 0% ~ (all equal)
HistogramNoLabels-12 0.00 0.00 ~ (all equal)