Fix documentation after reading via server. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Examining the existing documentation over the standard Go documentation server revealed some serious formatting flaws. Everything should be readable now.
ghost
assigned 
|
👍 |
juliusv
added a commit
that referenced
this pull request
Feb 18, 2013
Fix documentation after reading via server.
Closed
bwplotka
added a commit
that referenced
this pull request
Mar 17, 2022
* Add support for exemplars on constHistogram Co-authored-by: William Perron <[email protected]> Signed-off-by: William Perron <[email protected]> * remove GetExemplars function Signed-off-by: William Perron <[email protected]> * fixed linting warnings reduce repetition in constHistogram w/ exemplar Signed-off-by: William Perron <[email protected]> * Add values to correct bucket Signed-off-by: William Perron <[email protected]> * Misc fixes Co-authored-by: Francis Bogsanyi <[email protected]> Signed-off-by: William Perron <[email protected]> * avoid panic when there are fewer buckets than exemplars Co-authored-by: Arun Mahendra <[email protected]> Signed-off-by: William Perron <[email protected]> * Added MustNewMetricWithExemplars that wraps metrics with exemplar (#3) Changes: * Make sure to not "leak" dto.Metric * Reused upper bounds we already have for histogram * Common code for all types. Signed-off-by: Bartlomiej Plotka <[email protected]> Co-authored-by: Arun Mahendra <[email protected]> Co-authored-by: Bartlomiej Plotka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Examining the existing documentation over the standard Go documentation
server revealed some serious formatting flaws. Everything should be
readable now.