Document the issues of InstrumentHandler #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Obvious next step: Fix those issues.
|
Thank you @beorn7 I'll use direct instrumentation with request timing in the mean time. |
|
We need to fix the CI tests... unrelated to this (doc-comment only) change, though. Merging... |
|
@beorn7 Sorry for going a bit off topic, but is there any progress on fixing the InstrumentHandler? I am happy to help if needed 😄 |
|
I recommend explicit instrumentation for now. There is no easy "fix" for the issues of |
|
Cool 😄 Looking forward to seeing your implementation. If you need any help, let me know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Obvious next step: Fix those issues. (Which I'm already working on.)
@raliste This at least documents what you have run into in #200 .