Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfixes + Cut 1.13.1 + documenting release process. #1157

Merged
merged 5 commits into from
Nov 2, 2022

Conversation

bwplotka
Copy link
Member

@bwplotka bwplotka commented Nov 1, 2022

No description provided.

hairyhenderson and others added 4 commits November 1, 2022 16:20
…1148)

* Fix `CumulativeCount` value of `+Inf` bucket created from exemplar

Signed-off-by: Balint Zsilavecz <[email protected]>

* Update prometheus/metric_test.go

Co-authored-by: Bartlomiej Plotka <[email protected]>
Signed-off-by: Balint Zsilavecz <[email protected]>

* Clarify description of implicit `+Inf` bucket count

Signed-off-by: Balint Zsilavecz <[email protected]>

* Fix test variables

Signed-off-by: Balint Zsilavecz <[email protected]>

Signed-off-by: Balint Zsilavecz <[email protected]>
Co-authored-by: Bartlomiej Plotka <[email protected]>
* Fix race condition with Exemplar in Counter

Potential fix for #1145.

Signed-off-by: Fabian Stäber <[email protected]>

* Fix race condition with Exemplar in Counter

Signed-off-by: Fabian Stäber <[email protected]>

Signed-off-by: Fabian Stäber <[email protected]>
@bwplotka bwplotka requested review from kakkoyun and beorn7 November 1, 2022 16:37
@bwplotka bwplotka changed the base branch from main to release-1.13 November 1, 2022 16:41
@bwplotka
Copy link
Member Author

bwplotka commented Nov 1, 2022

cc @bboreham

Copy link
Member

@bboreham bboreham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Member

@kakkoyun kakkoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for taking care of it!

@kakkoyun kakkoyun merged commit 53e51c4 into release-1.13 Nov 2, 2022
@kakkoyun kakkoyun deleted the cut-1.13.1 branch November 2, 2022 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants