Enable same linters as the Prometheus repo itself #1056
Conversation
Signed-off-by: sazary <[email protected]>
Signed-off-by: sazary <[email protected]>
Signed-off-by: sazary <[email protected]>
Signed-off-by: sazary <[email protected]>
Signed-off-by: sazary <[email protected]>
Signed-off-by: sazary <[email protected]>
| max-same-issues: 0 | ||
| exclude-rules: | ||
| - path: _test.go | ||
| linters: |
There was a problem hiding this comment.
These linters don't seem to be enabled, no?
There was a problem hiding this comment.
golangci-lint has a list of default linters that are enabled by default, unless being disabled explicitly or implicitly. in the previous config they were disabled implicitly by using disable-all: true in this line
the default linters list is:
- deadcode
- errcheck
- gosimple
- govet
- ineffassign
- staticcheck
- structcheck
- typecheck
- unused
- varcheck
since in the main prometheus repo they left them enabled implicitly i did the same too but i understand that it could reduce readability.
do you want me to enable them in the config explicitly or leave them as they are?
There was a problem hiding this comment.
Having them explicit would be amazing. Also, this would prevent any unwanted issues, if we upgrade golangci-lint and decide to change their default preset.
| @@ -72,7 +72,8 @@ const ( | |||
| // | |||
| // The current default is GoRuntimeMemStatsCollection, so the compatibility mode with | |||
| // client_golang pre v1.12 (move to runtime/metrics). | |||
| func WithGoCollections(flags GoCollectionOption) goOption { | |||
| //nolint:staticcheck // Ignore SA1019 until v2. | |||
There was a problem hiding this comment.
Is staticcheck enabled? From the config above, it doesn't seem like it.
There was a problem hiding this comment.
same as #1056 (comment)
This will enable same linters in
golangci-lintas the base Prometheus repo, and fixes current issues that linters complain about.I've copied the config in that repo, specifically this version and removed some parts:
depguardbecause I don't know what are the policies in this repo about the dependencies, and the requirements of the source repo are not met hereI've split the changes applied for each linter into separate commits so that it's easier for review. I think the most critical changes that need review are in the 3dfd8d0 where I've fixed
errcheckissues.Signed-off-by: sazary [email protected]