client: Allow configuration of http client #1025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yolossn
changed the title
kakkoyun
reviewed
Apr 11, 2022
|
@yolossn Could you also handle DCO failures? |
yolossn
force-pushed
the
config_client
branch
2 times, most recently
from
9ac3af8 to
efe94be
Compare
kakkoyun
approved these changes
Apr 13, 2022
kakkoyun
requested changes
Apr 14, 2022
Signed-off-by: yolossn <[email protected]>
Update config documentation Signed-off-by: Kemal Akkoyun <[email protected]>
kakkoyun
approved these changes
Apr 21, 2022
kakkoyun
approved these changes
Apr 21, 2022
|
@bwplotka Any ideas why CircleCI is not properly functioning? Any way to re-run the checks? |
|
No idea, unfortunately. @yolossn do you mind pushing (even empty commit) ? |
Add api.Config validation to prevent confusion
|
@bwplotka looks like the maintainer has to click Approve and Run since this is a first time contribution.
|
|
Somehow, CircleCI ignores this PR. I'll merge it and if builds fail I'll fix it. |
|
I can't even do that @bwplotka could you please try to merge this? |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #932
Signed-off-by: yolossn [email protected]