Update query API to support timeouts

[josephwoodward]

Fixes #999

[kakkoyun]

Hey @josephwoodward, we plan to release soonish? Would you be able to have a look at this so that we can include it in the release?

[josephwoodward]

@kakkoyun Yes, no problem. IIRC the change is almost there, I'll have a look tonight.

[kakkoyun]

Looking good. Thanks a lot.

Would you consider adding the timeout to QueryRange as well? It's the same API.
https://prometheus.io/docs/prometheus/latest/querying/api/#range-queries

[josephwoodward]

Looking good. Thanks a lot.

Would you consider adding the timeout to QueryRange as well? It's the same API. https://prometheus.io/docs/prometheus/latest/querying/api/#range-queries

Ah yes, thanks. I missed that one.

[josephwoodward]

@kakkoyun This is ready for another review when you have the time, I've added support for timeouts to the QueryRange API as per your comment.

Also, I noticed that the tests currently don't validate the request parameters the HTTP client sends, is there an issue to fix this or is there more context I'm unaware of here?

[kakkoyun]

Also, I noticed that the tests currently don't validate the request parameters the HTTP client sends, is there an issue to fix this or is there more context I'm unaware of here?

I believe I don't have the context either. Feel free to open an issue so that we can discuss.

[kakkoyun]

LGTM.
Thanks for the contribution.

[bboreham]

At first glance I thought this would set the context timeout. I think there should at least be a documentation comment saying what the intended behaviour is.