Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registry is not checking for duplicate labels #471

Closed
beorn7 opened this issue Sep 29, 2018 · 0 comments · Fixed by #474
Closed

Registry is not checking for duplicate labels #471

beorn7 opened this issue Sep 29, 2018 · 0 comments · Fixed by #474
Assignees
Milestone

Comments

@beorn7
Copy link
Member

beorn7 commented Sep 29, 2018

While it should be impossible to create duplicate labels with the tools the library provides, you could of course create a dto.MetricFamily protobuf message with duplicate labels and inject them into an exposition. Thus, the validating code in the registry should check for that and prevent this kind of invalid exposition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant