Add support for HTTP header file #989
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danteu
force-pushed
the
issue-980
branch
2 times, most recently
from
bc58593 to
2a3774b
Compare
Resolves prometheus#980 Signed-off-by: Daniel Teunis <[email protected]>
|
Thanks for your pull request, I am working on a more general solution for this. |
|
Hi.. Look like this is not merged. we are looking for the header file solution. |
|
We are also interested in this feature, is it going to be added soon? can we reopen this PR? |
|
Re-opening this because there seems to be some increased interest in this feature. |
|
Any update on this topic? |
|
Little bump for an update @roidelapluie @electron0zero @danteu This would be very useful since sometimes credentials needs to be sent in a custom-header. This would enable reading these credentials from a mounted secret instead of a plain-text string (yuck). |
Signed-off-by: Daniel Teunis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #980
Signed-off-by: Daniel Teunis [email protected]