Add support for HTTP request body as file #987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a test for specifying a request body for HTTP probes. Signed-off-by: Daniel Teunis <[email protected]>
Resolves prometheus#391 Signed-off-by: Daniel Teunis <[email protected]>
electron0zero
approved these changes
Nov 15, 2022
|
Hi, I was wondering if this could be merged soon or if other changes are required. |
mem
reviewed
Dec 15, 2022
Signed-off-by: Marcelo Magallon <[email protected]>
mem
approved these changes
Dec 15, 2022
|
Hi! I'm also interested in this feature, what is preventing this to go forward to be merged? |
SuperQ
added a commit
that referenced
this pull request
May 16, 2023
* [CHANGE] Make Proxy Connect Headers consistent with Prometheus #1008 * [FEATURE] Add hostname parameter for TCP probe #981 * [FEATURE] Add support for HTTP request body as file #987 Signed-off-by: SuperQ <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #391