Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hostname param support for tls servername #947

Closed
wants to merge 1 commit into from

Conversation

BoringCat
Copy link

Modified for this case

  • need to monitor multiple domain which is dynamic resolve to different instance
  • instance handle multiple certificate and distinguish with SNI

To monitor more than thousands domain. I can not just create config for prometheus and blackbox-exporter dynamiced. If each domain need it own job and module. The config file will to large and may be affect prometheus performance.

So it will be perfect if single module can handle all request just with hostname param like http probe 👍

@roidelapluie
Copy link
Member

Thanks. This would require tests.

@electron0zero
Copy link
Member

fyi: #981 is also fixing the same issue.

@BoringCat
Copy link
Author

fyi: #981 is also fixing the same issue.

Well, after i make this PR. My target was changed. I need to known more infomation about the certificate. I'm now creating my own exporter. So I have no time work for this. If #981 can fix it and pass test. Please close this.

@electron0zero
Copy link
Member

fyi: #981 is also fixing the same issue.

Well, after i make this PR. My target was changed. I need to known more infomation about the certificate. I'm now creating my own exporter. So I have no time work for this. If #981 can fix it and pass test. Please close this.

closing in favor of #981

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants