Make caser a local varialbe, not a global one. #927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cases.Caser returned by calling cases.Title *cannot* be shared among goroutines. This might happen when Prometheus tries to scrape multiple targets at the same time. From the docs: A Caser may be stateful and should therefore not be shared between goroutines. Fixes: #922 Signed-off-by: Marcelo E. Magallon <[email protected]>
mem
force-pushed
the
mem/make_caser_local
branch
from
a0a6364 to
19016d2
Compare
mem
added a commit
to grafana/synthetic-monitoring-agent
that referenced
this pull request
Jun 14, 2022
There's an open PR in BBE to fix an issue with reusing a golang.org/x/text/cases/Caser: prometheus/blackbox_exporter#927 Signed-off-by: Marcelo E. Magallon <[email protected]>
mem
added a commit
to grafana/synthetic-monitoring-agent
that referenced
this pull request
Jun 14, 2022
There's an open PR in BBE to fix an issue with reusing a golang.org/x/text/cases/Caser: prometheus/blackbox_exporter#927 Signed-off-by: Marcelo E. Magallon <[email protected]>
| // | ||
| // A Caser may be stateful and should therefore not be shared between goroutines. | ||
| // | ||
| // Issue: https://github.com/prometheus/blackbox_exporter/issues/922 |
There was a problem hiding this comment.
I don't think it is necessary to point to the gh issue here
There was a problem hiding this comment.
I felt it was necessary to keep the reference close to the code because the original version is what I would have written, too. The wording in the docs, "a Caser may", sounds like if that were the actual case, the individual Caser implementations would spell that out. Given that in this particular instance there no such note, I would have assumed that this Caser is not stateful.
Thanks for the review and merging this!
roidelapluie
approved these changes
Jun 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cases.Caser returned by calling cases.Title cannot be shared among
goroutines. This might happen when Prometheus tries to scrape multiple
targets at the same time. From the docs:
A Caser may be stateful and should therefore not be shared between
goroutines.
Fixes: #922
Signed-off-by: Marcelo E. Magallon [email protected]