Add control of recursion desired flag for DNS probes #859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This defaults recursion desired to on to preserve existing behaviour, but allows it to be configured. Signed-off-by: David Leadbeater <[email protected]>
SuperQ
reviewed
Jan 22, 2022
SuperQ
reviewed
Jan 22, 2022
SuperQ
requested changes
Jan 22, 2022
- Drop "desired" - Drop go 1.17 compat, will be switched entirely to go 1.17 elsewhere Signed-off-by: David Leadbeater <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This defaults recursion desired to on to preserve existing behaviour,
but allows it to be configured.
Asked for in a comment in #474 and generally useful.
Signed-off-by: David Leadbeater [email protected]