Fix body_size_limit negative handling #838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When body_size_limit is 0 (either explicitly or implicitly because it wasn't specified) or less, we are setting it to math.MaxInt64. It turns out that the implementation in http.MaxBytesReader tries to add 1 to the specified value, and it wraps around. After that, it tries to use the result to index an slice, causing it to panic. Work around this by setting the limit to math.MaxInt64 - 1. Also, if body_size_limit is exactly 0, leave it like that. That causes the code to avoid setting up the limiter, saving some extra processing. Signed-off-by: Marcelo E. Magallon <[email protected]>
|
Merge without review? |
Sorry, I did not want to leave a panic in the code hanging around like that. I'm more than glad to make any changes. |
|
For the record, I'm looking at why the existing tests did not catch this, as the path that was failing is the default one. I in particular missed it when testing by hand because I did not connect the dots in my head that when I changed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When body_size_limit is 0 (either explicitly or implicitly because it
wasn't specified) or less, we are setting it to math.MaxInt64. It turns
out that the implementation in http.MaxBytesReader tries to add 1 to the
specified value, and it wraps around. After that, it tries to use the
result to index an slice, causing it to panic.
Work around this by setting the limit to math.MaxInt64 - 1.
Also, if body_size_limit is exactly 0, leave it like that. That causes
the code to avoid setting up the limiter, saving some extra processing.
Closes: #837
Signed-off-by: Marcelo E. Magallon [email protected]