Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable TLS certificate check in DoT #644

Merged
merged 1 commit into from
Jun 18, 2020

Conversation

edevil
Copy link
Contributor

@edevil edevil commented Jun 17, 2020

Similar to TLS probe

@brian-brazil
Copy link
Contributor

Should we have all of the standard tls config stuff here?

@edevil
Copy link
Contributor Author

edevil commented Jun 17, 2020

@brian-brazil I had that question. But since there already is a TLS probe with those options, I suppose the logical thing is to use that one to test for custom TLS stuff, if you need it, and just disable TLS verification in DoT.

In other words, use the DNS and TLS probe in tandem. What do you think?

@brian-brazil
Copy link
Contributor

My point is that we already have a standard way of producing a tls.Config, so you should use that.

@edevil
Copy link
Contributor Author

edevil commented Jun 17, 2020

I added the TLSConfig block to the DNS probe.

@brian-brazil brian-brazil merged commit e0875eb into prometheus:master Jun 18, 2020
@brian-brazil
Copy link
Contributor

Thanks!

@edevil
Copy link
Contributor Author

edevil commented Jun 18, 2020

@brian-brazil No, thank you! Are there any plans to release a new version of blackbox_exporter?

@brian-brazil
Copy link
Contributor

Hopefully in the next few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants