[BUGFIX] disable ip protocol fallback and tests #540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
genofire
referenced
this pull request
Oct 23, 2019
* travisci skip ipv6 dns tests Signed-off-by: Thor <[email protected]>
prober/dns_test.go
Outdated
| @@ -226,27 +230,23 @@ func TestAuthoritativeDNSResponse(t *testing.T) { | |||
| }{ | |||
| { | |||
| config.DNSProbe{ | |||
| IPProtocol: "ipv4", | |||
| QueryName: "example.com", | |||
| QueryName: "example.com", | |||
There was a problem hiding this comment.
Leave these as v4 please.
There was a problem hiding this comment.
It doesn't matter either way.
There was a problem hiding this comment.
thats the problem, on my notebook some test failures if there is no fallback and it try only ipv4
| }, false, | ||
| }, | ||
| { | ||
| config.DNSProbe{ | ||
| IPProtocol: "ipv4", | ||
| QueryName: "example.com", | ||
| IPProtocol: "ip4", |
There was a problem hiding this comment.
Hmm, are we missing a sanity check on the value of this?
There was a problem hiding this comment.
jep, but please let somebody else do it ...
Signed-off-by: Martin/Geno <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fallbackIPProtocolinchooseProtocol()(prober/utils.go) was never usedIPProtocolduring testingipv4is a wrong value, it should beip4orip6