Export TLS version #538
Merged
Export TLS version #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Version information should be exposed as an info metric like this: This avoids the problems with NaN in unknown. |
|
Right! I initially followed the format of |
Signed-off-by: Silke Hofstra <[email protected]>
Signed-off-by: Silke Hofstra <[email protected]>
silkeh
force-pushed
the
add-tls-version
branch
from
87104ca to
4503a62
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the TLS version to the exported variables, or NaN when it is unknown (maybe that should be 0 instead?). All currently available TLS versions are covered. SSL3 is not, as it is not TLS and will be removed in Go 1.14 (See golang/go#32716).