Initialize ICMP echo ID and sequence to random values #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should help preventing issues with some network devices that have trouble NATing ICMP packets with the same ID and sequence nubmer but a different source IP address. Currently, this can happen if the blackbox_exporter runs in a container (the ID is set to the PID, which is typically 1 in a container), and serveral blackbox_exporters are restarted at the same time (the sequence numbers are reset to zero and stay in sync). This commit sets the ICMP echo ID to a random value if the PID is 1, and initializes the sequence number at a random offset. See prometheus#411 for details. Signed-off-by: Benoît Knecht <[email protected]>
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help preventing issues with some network devices that have
trouble NATing ICMP packets with the same ID and sequence nubmer but a
different source IP address.
Currently, this can happen if the blackbox_exporter runs in a container
(the ID is set to the PID, which is typically 1 in a container), and
serveral blackbox_exporters are restarted at the same time (the sequence
numbers are reset to zero and stay in sync).
This commit sets the ICMP echo ID to a random value if the PID is 1, and
initializes the sequence number at a random offset.
See #411 for details.