http: Prevent logging confusing error message #1059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adriansr
force-pushed
the
fail_if_not_ssl_final_req_log
branch
from
617a4e5 to
5e8e5e6
Compare
When FailIfNotSSL is set, the error message: > Final request was not over SSL is logged even if a previous error has prevented the request to complete, for example when it fails due to a timeout or connection error. This updates the logic around the log message so it's printed when an otherwise successful request is not performed over SSL and that causes the probe to fail. Signed-off-by: Adrian Serrano <[email protected]>
adriansr
force-pushed
the
fail_if_not_ssl_final_req_log
branch
from
5e8e5e6 to
68ccd8c
Compare
Signed-off-by: Adrian Serrano <[email protected]>
adriansr
force-pushed
the
fail_if_not_ssl_final_req_log
branch
from
68ccd8c to
6637eca
Compare
electron0zero
approved these changes
Jun 5, 2023
SuperQ
added a commit
that referenced
this pull request
Apr 9, 2024
* [FEATURE] Allow to get Probe logs by target #1063 * [FEATURE] Log errors from probe #1091 * [BUGFIX] Prevent logging confusing error message #1059 * [BUGFIX] Explicit registration of internal exporter metrics 1060 Signed-off-by: SuperQ <[email protected]>
Merged
SuperQ
added a commit
that referenced
this pull request
Apr 9, 2024
* [FEATURE] Allow to get Probe logs by target #1063 * [FEATURE] Log errors from probe #1091 * [BUGFIX] Prevent logging confusing error message #1059 * [BUGFIX] Explicit registration of internal exporter metrics 1060 Signed-off-by: SuperQ <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When FailIfNotSSL is set, the error message:
is logged even if a previous error has prevented the request to complete, for example when it fails due to a timeout or connection error.
This updates the logic around the log message so it's printed when an otherwise successful request is not performed over SSL and that causes the probe to fail.