ensure resp.Body is discarded to avoid broken tcp sockets (#348)

Signed-off-by: Thomas Maier <[email protected]>
prometheus · Aug 14, 2018 · 9a02cbf · 9a02cbf
1 parent 2a04b8e
commit 9a02cbf
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/prober/http.go b/prober/http.go
@@ -296,7 +296,10 @@ func ProbeHTTP(ctx context.Context, target string, module config.Module, registr
 	if err != nil && resp == nil {
 		level.Error(logger).Log("msg", "Error for HTTP request", "err", err)
 	} else {
-		defer resp.Body.Close()
+		defer func() {
+			io.Copy(ioutil.Discard, resp.Body)
+			resp.Body.Close()
+		}()
 		level.Info(logger).Log("msg", "Received HTTP response", "status_code", resp.StatusCode)
 		if len(httpConfig.ValidStatusCodes) != 0 {
 			for _, code := range httpConfig.ValidStatusCodes {