Truncating fields that are sent to slack #2774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prashbnair
force-pushed
the
issue-slack
branch
from
9106aa7 to
b83a629
Compare
|
Thanks for your contribution. I think we should limit the length of the fields we send to slack, like we do for pagerduty (IIRC), instead of limiting the number of alerts. |
prashbnair
force-pushed
the
issue-slack
branch
from
b83a629 to
733759b
Compare
|
Removed the max alerts config parameter and truncated the field that is the longest as per https://github.com/prometheus/alertmanager/blob/main/template/default.tmpl#L15 |
prashbnair
changed the title
notify/slack/slack.go
Outdated
Comment on lines
96
to
100
| key, err := notify.ExtractGroupKey(ctx) | ||
|
|
||
| if err != nil { | ||
| return false, err | ||
| } |
There was a problem hiding this comment.
i would move this block inside the if truncated { ... } block.
prashbnair
force-pushed
the
issue-slack
branch
from
733759b to
4079c29
Compare
notify/slack/slack.go
Outdated
| if err != nil { | ||
| return false, err | ||
| } | ||
| level.Debug(n.logger).Log("msg", "Truncated text", "text", title, "key", key) |
There was a problem hiding this comment.
Suggested change
| level.Debug(n.logger).Log("msg", "Truncated text", "text", title, "key", key) | |
| level.Debug(n.logger).Log("msg", "Truncated title", "text", title, "key", key) |
correcting the logic to trucate fields instead of dropping alerts in the slack integration Signed-off-by: Prashant Balachandran <[email protected]>
prashbnair
force-pushed
the
issue-slack
branch
from
4079c29 to
a79a4ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Prashant Balachandran [email protected]
Fixed issue #2769