Add feature flag to enable discovery and use of public IPaddr for clustering. #2719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stering. Before this change, Alertmanager would refuse to startup if using a advertise address binding to any address (0.0.0.0), and the host only had an interface with a public IP address. After this change we feature flag permitting the use of a discovered public address for cluster gossiping. Signed-off-by: Devin Trejo <[email protected]>
Signed-off-by: Devin Trejo <[email protected]>
dtrejod
force-pushed
the
dt/public-addr-advertise
branch
from
d414408 to
cbea6e7
Compare
cmd/alertmanager/main.go
Outdated
| reconnectInterval = kingpin.Flag("cluster.reconnect-interval", "Interval between attempting to reconnect to lost peers.").Default(cluster.DefaultReconnectInterval.String()).Duration() | ||
| peerReconnectTimeout = kingpin.Flag("cluster.reconnect-timeout", "Length of time to attempt to reconnect to a lost peer.").Default(cluster.DefaultReconnectTimeout.String()).Duration() | ||
| tlsConfigFile = kingpin.Flag("cluster.tls-config", "[EXPERIMENTAL] Path to config yaml file that can enable mutual TLS within the gossip protocol.").Default("").String() | ||
| allowInsecureAdvertise = kingpin.Flag("cluster.allow-insecure-public-advertise-address", "[EXPERIMENTAL] Allow alertmanager to discover and listen on a public address.").Bool() |
There was a problem hiding this comment.
Suggested change
| allowInsecureAdvertise = kingpin.Flag("cluster.allow-insecure-public-advertise-address", "[EXPERIMENTAL] Allow alertmanager to discover and listen on a public address.").Bool() | |
| allowInsecureAdvertise = kingpin.Flag("cluster.allow-insecure-public-advertise-address-discovery", "[EXPERIMENTAL] Allow alertmanager to discover and listen on a public address.").Bool() |
Maybe we should make it clear in the name of the flag that it is only for discovery?
Signed-off-by: Devin Trejo <[email protected]>
cluster/advertise.go
Outdated
| } | ||
|
|
||
| // discoverAdvertiseAddress will attempt to get a single IP address to use as | ||
| // the advertise address when one is not explictly provided. It defualts to |
There was a problem hiding this comment.
Suggested change
| // the advertise address when one is not explictly provided. It defualts to | |
| // the advertise address when one is not explicitly provided. It defaults to |
cluster/advertise.go
Outdated
| if ip == nil { | ||
| return nil, errors.Errorf("failed to parse private IP '%s'", privateIP) | ||
| if addr == "" { | ||
| return nil, errors.New("no public IP found, explicit advertise addr not provided") |
There was a problem hiding this comment.
Suggested change
| return nil, errors.New("no public IP found, explicit advertise addr not provided") | |
| return nil, errors.New("no private/public IP found, explicit advertise addr not provided") |
… message. Signed-off-by: Devin Trejo <[email protected]>
|
close/reopen to trigger ci |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, Alertmanager would refuse to startup if using a
advertise address binding to any address (0.0.0.0), and the host only
had an interface with a public IP address. After this change we feature
flag permitting the use of a discovered public address for cluster
gossiping.