This repository has been archived by the owner on Aug 13, 2019. It is now read-only.
Remove FromData function #540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhulongcheng
force-pushed
the
rm-fromdata
branch
from
eca72fb to
67f32dd
Compare
|
should also add an entry in the CHANGELOG file. |
zhulongcheng
force-pushed
the
rm-fromdata
branch
from
67f32dd to
e4d3db7
Compare
Signed-off-by: zhulongcheng <[email protected]>
zhulongcheng
force-pushed
the
rm-fromdata
branch
from
e4d3db7 to
c99069e
Compare
|
Thanks! |
|
Thanos uses this function https://github.com/improbable-eng/thanos/blob/master/pkg/compact/downsample/aggr.go#L89 :( |
|
So this is fine as long as we can use replacement @sylr, right? (: The question, can we? I will look at it soon. |
|
this has been reverted by #600 so it's fine. |
|
xD why? |
|
because cortex also uses it. |
|
Cool, thanks for clarification <3
…On Fri, 10 May 2019 at 16:09, Krasi Georgiev ***@***.***> wrote:
because cortex also uses it.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#540 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABVA3O23MP65HD5D2L6AOE3PUWF2HANCNFSM4G3XZV7Q>
.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The role of
FromDatafunction has been replaced bypool.Get.Related PR: #118
https://github.com/prometheus/tsdb/pull/118/files#diff-5047d434b918cce51937ad6204d8afb0L358