This repository has been archived by the owner on Aug 13, 2019. It is now read-only.
Missing the len of crc32 when calculating maxLen in WriteChunks #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@naivewong The change looks good to me, thanks! You need to sign off on the commit before this can be merged though. See: https://github.com/prometheus/prometheus/wiki/DCO-signing |
naivewong
force-pushed
the
patch-1
branch
3 times, most recently
from
bd0f3f2 to
83e5730
Compare
Signed-off-by: naivewong <[email protected]>
|
@gouthamve Thanks! And is now ok? |
radeklesniewski
pushed a commit
to SabreOSS/tsdb
that referenced
this pull request
Jan 18, 2019
…etheus-junkyard#494) Signed-off-by: naivewong <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.