This repository has been archived by the owner on Aug 13, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 179
fix windows tests #469
Merged
krasi-georgiev
merged 9 commits into
prometheus-junkyard:master
from
krasi-georgiev:windows-tests
Dec 13, 2018
Merged
fix windows tests #469
krasi-georgiev
merged 9 commits into
prometheus-junkyard:master
from
krasi-georgiev:windows-tests
Dec 13, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Krasi Georgiev <[email protected]>
krasi-georgiev
force-pushed
the
windows-tests
branch
3 times, most recently
from
December 11, 2018 13:03
adf7278
to
c36a2f2
Compare
Signed-off-by: Krasi Georgiev <[email protected]>
krasi-georgiev
force-pushed
the
windows-tests
branch
from
December 11, 2018 13:08
c36a2f2
to
8714dc8
Compare
Signed-off-by: Krasi Georgiev <[email protected]>
Signed-off-by: Krasi Georgiev <[email protected]>
Closed
still green even after 10 re-triggers. |
Signed-off-by: Krasi Georgiev <[email protected]>
gouthamve
reviewed
Dec 13, 2018
Signed-off-by: Krasi Georgiev <[email protected]>
Signed-off-by: Krasi Georgiev <[email protected]>
gouthamve
reviewed
Dec 13, 2018
Signed-off-by: Krasi Georgiev <[email protected]>
Signed-off-by: Krasi Georgiev <[email protected]>
krasi-georgiev
force-pushed
the
windows-tests
branch
from
December 13, 2018 11:29
1730f4c
to
ce06e4d
Compare
@gouthamve I have reverted the removed tests and disabled these for windows |
gouthamve
approved these changes
Dec 13, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough. I'll try to remove the build tag when I get time.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #420
Signed-off-by: Krasi Georgiev [email protected]