Delete temp checkpoint folder on error.

[krasi-georgiev]

No description provided.

[krasi-georgiev]

cc @codesome

[codesome]

Instead of manually appending fileutil.TmpExt everywhere, would it be better to have a function call like fileutil.TmpDir which would take the dir and append fileutil.TmpExt to it? In case we want to change the logic of naming temp dir, this would come handy (example ioutil.TempDir).

package fileutil

func TmpDir(dir string) string {
    return dir + TmpExt
}

tmp := fileutil.TmpDir(path)

fileutil.TmpExt would still be present if it is needed somewhere.

[krasi-georgiev]

yeah I like the idea, but I prefer to be more explicit and tmp := fileutil.TmpDir(path) might be a bit strange. What does it do? create a tmp dir? copies to a tmp dir ?
refactoring is easy enough so lets keep as is and will change if needed.

[krasi-georgiev]

@gouthamve just when I was about to leave it to the windows users to fix 😜
this I realised it is an easy fix so now it passes for windows as well.

[krasi-georgiev]

after having another look it is a terrible solution and very likely to brake but will keep it open as a reminder to think how ti fix properly for linux and windows.

[krasi-georgiev]

Refactored with a different approach. wal.Close() is now non blocking so it we just call it again and remove all tmp folder.

[krasi-georgiev]

cc @codesome

[codesome]

LGTM

[gouthamve]

LGTM