This repository has been archived by the owner on Aug 13, 2019. It is now read-only.
Persist series without allocating the full set #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change index persistence for series to not be accumulated in memory
before being written as one large batch. `Labels` and `ChunkMeta`
objects are reused.
This cuts down memory spikes during compaction of multiple blocks
significantly.
As part of the the Index{Reader,Writer} now have an explicit notion of
symbols and series must be inserted in order.
gouthamve
approved these changes
Aug 10, 2017
|
|
||
| // Reference on the original slice to use for postings mapping. | ||
| series := h.series[:] | ||
| h.mtx.RUnlock() |
There was a problem hiding this comment.
Defer pattern is better as both are co-located? The instantiation of the blockQuerier should be instantaneous AFAICS.
There was a problem hiding this comment.
Index(), Chunks(), and Tombstones() do or may in the future lock the mutex too. So defer would call deadlocking here.
|
Yup, got a bit more complex. But the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change index persistence for series to not be accumulated in memory
before being written as one large batch.
LabelsandChunkMetaobjects are reused.
This cuts down memory spikes during compaction of multiple blocks
significantly.
As part of the the Index{Reader,Writer} now have an explicit notion of
symbols and series must be inserted in order.
@gouthamve
This does not solve all of it yet but has very positive effects. The next effective optimizations are likely around the postings lists.
Max heap usage (using
max_over_time):