-
Notifications
You must be signed in to change notification settings - Fork 707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup GitVersion #39
Setup GitVersion #39
Conversation
Also somewhat alarming is that AppVeyor does not fail the build when promu fails. Should also be investigated. |
You can look at the build triggered to see the look of the version, btw. This build was |
looking into if i can add you to appveyour... |
this is because promu is not signaling failure here: https://github.com/prometheus/promu/blob/master/cmd/build.go#L112 it still doesnt resolve the root cause, but will give us chance to dig further. |
Nice find! I'll wait for it to get merged, then |
Regarding users on appveyor. They are added at https://ci.appveyor.com/team, and need your email. I added the gmail you used to commit to this repository with as an administrator, hope that is the same you used to sign up there with. /m |
@martinlindhe Ah, excellent, I just got the email as well. Thanks, that'll hopefully make it possible to investigate from both ends then |
That's great! |
a4f085a
to
d617541
Compare
d617541
to
4c39660
Compare
Fixed (turns out that the file was written with some weird encoding when using |
nice work! maybe the promu project is interested in your solution as it can remove the need to manually update a VERSION file |
Will probably need a rewrite for cross-platform compatibility then - GitVersion is a C#-project delivered as a Windows executable which doesn't seem to even run on Mono... I'll give their algorithm a look though, might be simple enough to reimplement |
Ah, didn't think of that! Nevermind then :) |
PS, prometheus/promu#50 is now merged |
So, this works fine on my machine, but AppVeyor logs this:
command failed: fork/exec c:\go\bin\go.exe: invalid argument
Probably related to it also seeming to mangle the parameters sent to promu. Haven't figured out why yet.
@martinlindhe Is there some way to share access to the AppVeyor account? I can't do anything much more sophisticated than adding echo-commands to the build script and rerunning.