Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup GitVersion #39

Merged
merged 1 commit into from
Oct 18, 2016
Merged

Setup GitVersion #39

merged 1 commit into from
Oct 18, 2016

Conversation

carlpett
Copy link
Collaborator

So, this works fine on my machine, but AppVeyor logs this:
command failed: fork/exec c:\go\bin\go.exe: invalid argument

Probably related to it also seeming to mangle the parameters sent to promu. Haven't figured out why yet.
@martinlindhe Is there some way to share access to the AppVeyor account? I can't do anything much more sophisticated than adding echo-commands to the build script and rerunning.

@carlpett
Copy link
Collaborator Author

Also somewhat alarming is that AppVeyor does not fail the build when promu fails. Should also be investigated.

@carlpett
Copy link
Collaborator Author

You can look at the build triggered to see the look of the version, btw. This build was 0.1.1-PullRequest.39+4

@martinlindhe
Copy link
Collaborator

looking into if i can add you to appveyour...

@martinlindhe
Copy link
Collaborator

Also somewhat alarming is that AppVeyor does not fail the build when promu fails. Should also be investigated.

this is because promu is not signaling failure here: https://github.com/prometheus/promu/blob/master/cmd/build.go#L112
I sent a patch about this just now: prometheus/promu#50, which also outputs the "go" parameters that was failing.

it still doesnt resolve the root cause, but will give us chance to dig further.

@carlpett
Copy link
Collaborator Author

Nice find! I'll wait for it to get merged, then

@martinlindhe
Copy link
Collaborator

Regarding users on appveyor. They are added at https://ci.appveyor.com/team, and need your email.

I added the gmail you used to commit to this repository with as an administrator, hope that is the same you used to sign up there with.

/m

@carlpett
Copy link
Collaborator Author

@martinlindhe Ah, excellent, I just got the email as well. Thanks, that'll hopefully make it possible to investigate from both ends then

@martinlindhe
Copy link
Collaborator

That's great!

@carlpett carlpett changed the title WIP: Setup GitVersion Setup GitVersion Oct 18, 2016
@carlpett
Copy link
Collaborator Author

Fixed (turns out that the file was written with some weird encoding when using Tee-Object)

@martinlindhe
Copy link
Collaborator

nice work! maybe the promu project is interested in your solution as it can remove the need to manually update a VERSION file

@martinlindhe martinlindhe merged commit a1910c3 into master Oct 18, 2016
@carlpett
Copy link
Collaborator Author

Will probably need a rewrite for cross-platform compatibility then - GitVersion is a C#-project delivered as a Windows executable which doesn't seem to even run on Mono... I'll give their algorithm a look though, might be simple enough to reimplement

@martinlindhe
Copy link
Collaborator

Ah, didn't think of that! Nevermind then :)

@martinlindhe
Copy link
Collaborator

PS, prometheus/promu#50 is now merged

@carlpett carlpett deleted the setup-gitversion branch May 12, 2018 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants