scheuduled_task: fix memory leaks

Signed-off-by: Jan-Otto Kröpke <[email protected]>
prometheus-community · Sep 28, 2024 · a63a6ff · a63a6ff
1 parent e17daf2
commit a63a6ff
Showing 1 changed file with 3 additions and 7 deletions.
diff --git a/pkg/collector/scheduled_task/scheduled_task.go b/pkg/collector/scheduled_task/scheduled_task.go
@@ -59,6 +59,8 @@ const (
 	SCHED_S_TASK_HAS_NOT_RUN TaskResult = 0x00041303
 )
 
+var taskStates = []string{"disabled", "queued", "ready", "running", "unknown"}
+
 type scheduledTask struct {
 	Name            string
 	Path            string
@@ -192,8 +194,6 @@ func (c *Collector) Collect(_ *types.ScrapeContext, logger *slog.Logger, ch chan
 	return nil
 }
 
-var TASK_STATES = []string{"disabled", "queued", "ready", "running", "unknown"}
-
 func (c *Collector) collect(ch chan<- prometheus.Metric) error {
 	scheduledTasks, err := c.getScheduledTasks()
 	if err != nil {
@@ -206,7 +206,7 @@ func (c *Collector) collect(ch chan<- prometheus.Metric) error {
 			continue
 		}
 
-		for _, state := range TASK_STATES {
+		for _, state := range taskStates {
 			var stateValue float64
 
 			if strings.ToLower(task.State.String()) == state {
@@ -320,10 +320,6 @@ func (c *Collector) initializeScheduleService(initErrCh chan<- error) {
 				return
 			}
 
-			defer func(res *ole.VARIANT) {
-				_ = res.Clear()
-			}(res)
-
 			rootFolderObj := res.ToIDispatch()
 			defer rootFolderObj.Release()