Add smartmontools to container image #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch to using Alpine container and install smartmontools so the exporter can use the smartctl binary. Signed-off-by: SuperQ <[email protected]>
|
I'm thinking this will not work. Though I haven't tested it. Alpine is made without glibc. I think the build, when done without CGO_ENABLED=0 fails to start properly in alpine due to the lack of shared library. The released binaries though seem to be made with CGO_ENABLED=0 I think? They work for sure, as I've tested that combination https://github.com/pnnl-miscscripts/miscscripts/blob/master/containers/smartctl-exporter/Dockerfile |
|
Prometheus builds are static, they do not use any libc. |
|
Its been a while since I build statically linked binaries with go. is CGO_ENABLED=0 no longer required? |
|
No, |
sysadmind
approved these changes
Aug 8, 2022
SuperQ
added a commit
that referenced
this pull request
Oct 3, 2022
Breaking Changes: All configuration has been moved from the config file to command line flags. * [CHANGE] Refactor exporter config #68 * [BUGFIX] Fix smartctl command args to avoid wakeups #74 * [ENHANCEMENT] Add smartmontools to container image #51 Signed-off-by: SuperQ <[email protected]>
Merged
SuperQ
added a commit
that referenced
this pull request
Oct 3, 2022
Breaking Changes: All configuration has been moved from the config file to command line flags. * [CHANGE] Refactor exporter config #68 * [BUGFIX] Fix smartctl command args to avoid wakeups #74 * [ENHANCEMENT] Add smartmontools to container image #51 Signed-off-by: SuperQ <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to using Alpine container and install smartmontools so the
exporter can use the smartctl binary.
Signed-off-by: SuperQ [email protected]