Cut 0.4.0 release #87
Conversation
Also clarifies the implication of using --enable-label-apis in the help text and README. Signed-off-by: Simon Pasquier <[email protected]> (cherry picked from commit 843939a)
jan--f
force-pushed
the
cut-0.4.0-release
branch
from
257a09a to
db47dfa
Compare
Fixes prometheus-community#86 Signed-off-by: Jan Fajerski <[email protected]>
jan--f
force-pushed
the
cut-0.4.0-release
branch
from
db47dfa to
6511f18
Compare
|
We technically haven't done this since the 0.1 release of prom-label-proxy, however, would you mind cutting the release/tagging the release in a release-0.4 branch? Also, I would vote against pulling #79 into the master branch in this PR that cuts a release circumventing the approval process in the PR, because I think it makes it hard to track the origin of the code change and is messier |
| "any labels endpoint does not support selectors, the injected matcher will have no effect.") | ||
| flagset.StringVar(&unsafePassthroughPaths, "unsafe-passthrough-paths", "", "Comma delimited allow list of exact HTTP path segments that should be allowed to hit upstream URL without any enforcement. "+ | ||
| "This option is checked after Prometheus APIs, you cannot override enforced API endpoints to be not enforced with this option. Use carefully as it can easily cause a data leak if the provided path is an important "+ | ||
| "API (like /api/v1/configuration) which isn't enforced by prom-label-proxy. NOTE: \"all\" matching paths like \"/\" or \"\" and regex are not allowed.") |
There was a problem hiding this comment.
| "API (like /api/v1/configuration) which isn't enforced by prom-label-proxy. NOTE: \"all\" matching paths like \"/\" or \"\" and regex are not allowed.") | |
| "API (like /api/v1/status/config) which isn't enforced by prom-label-proxy. NOTE: \"all\" matching paths like \"/\" or \"\" and regex are not allowed.") |
Sure, no problem. I pulled in #79 on @simonpasquier's request. I'll add it to the new PR as well, lets discuss there. If the PR gets approval I'm also happy to rebase. |
This also pulls in #79.
Fixes #86