[prometheus] fix: Add apiVersion and kind to STS persistent volume claim #4610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API version and kind is added by API server which causes a drift in argo cd state Signed-off-by: Grzegorz Głąb <[email protected]>
grzesuav
requested review from
gianrubio,
naseemkullah,
Xtigyro,
zanhsieh and
zeritti
as code owners
|
This is what I see in argocd, adding the missing field would resolve this and it is not doing any charm 
|
grzesuav
changed the title
Signed-off-by: Grzegorz Głąb <[email protected]>
|
@gianrubio @naseemkullah @Xtigyro @zanhsieh @zeritti can you take a look ? |
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Add explicitly
persistentVolumeClaimAPI version and kind - they are added by API server which causes a drift in argo cd state - and having them do not make any charm.Special notes for your reviewer
Checklist
[prometheus-couchdb-exporter])